[webkit-reviews] review granted: [Bug 52650] make file expansion use the file at the svn revision the diff was created at : [Attachment 79310] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 52650: make file expansion use the file at the svn revision the diff was
created at
https://bugs.webkit.org/show_bug.cgi?id=52650

Attachment 79310: Patch
https://bugs.webkit.org/attachment.cgi?id=79310&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79310&action=review

Looks good though.

> Websites/bugs.webkit.org/code-review.js:424
> +    var suffix = revision ? '?p=' + revision : '';

suffix seems a bit odd for a name here.  You're constructing a query, with a
single p= parameter.