[webkit-reviews] review granted: [Bug 52654] Add a test that calling window.open with an empty URL does not trigger an assertion or cause a crash : [Attachment 79315] Patch

Tue Jan 18 13:08:31 PST 2011

Adam Roben (aroben) <aroben at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 52654: Add a test that calling window.open with an empty URL does not
trigger an assertion or cause a crash
https://bugs.webkit.org/show_bug.cgi?id=52654

Attachment 79315: Patch
https://bugs.webkit.org/attachment.cgi?id=79315&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79315&action=review

> LayoutTests/fast/dom/Window/open-window-empty-url.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

Just <!DOCTYPE html> should be enough. That's what HTML5 recommends.

> LayoutTests/fast/dom/Window/open-window-empty-url.html:21
> +    <script type="text/javascript">
> +	   if (window.layoutTestController) {
> +	       layoutTestController.dumpAsText();
> +	       layoutTestController.waitUntilDone();
> +	       layoutTestController.setCanOpenWindows();
> +	   }
> +	   var newWindow = window.open("");
> +	   newWindow.close();
> +	   document.getElementById("results").innerText = "PASS: Calling
window.open() with an empty URL did not trigger any assertions or cause any
crashes.";
> +	   if (window.layoutTestController)
> +	       layoutTestController.notifyDone();
> +    </script>
> +</body>

Since the whole test proceeds synchronously (before the page has even finished
loading), there's no need for waitUntilDone/notifyDone.