[webkit-reviews] review granted: [Bug 52646] Implement NPN_PopUpContextMenu : [Attachment 79304] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 12:07:55 PST 2011


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 52646: Implement NPN_PopUpContextMenu
https://bugs.webkit.org/show_bug.cgi?id=52646

Attachment 79304: Patch
https://bugs.webkit.org/attachment.cgi?id=79304&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79304&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:209
> +    NPCocoaEvent *m_currentMouseEvent;

* on the wrong side. Or at least, I think it is, assuming NPCocoaEvent is no an
objective-c object.

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:492
> +	       NPCocoaEvent *previousMouseEvent = m_currentMouseEvent;

* on wrong side.


More information about the webkit-reviews mailing list