[webkit-reviews] review denied: [Bug 49334] Implement Default Ruby Overhang Behavior : [Attachment 78066] Detect ruby blocks in findNextLineBreak and take overhang into account when determining whether or not the ruby block fits on the ine.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 12:01:10 PST 2011


Dave Hyatt <hyatt at apple.com> has denied Eric Mader <emader at apple.com>'s request
for review:
Bug 49334: Implement Default Ruby Overhang Behavior
https://bugs.webkit.org/show_bug.cgi?id=49334

Attachment 78066: Detect ruby blocks in findNextLineBreak and take overhang
into account when determining whether or not the ruby block fits on the ine.
https://bugs.webkit.org/attachment.cgi?id=78066&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Include changes in a patch please, rather than just posting them in comments. 
It's easier to comment on the code if it's in the pretty-printed form.

I still think you need to cap the amount you're willing to overhang.

Also, the change to shrink the font-size to 50% has nothing to do with this
bug, and we should just do that in a separate change.


More information about the webkit-reviews mailing list