[webkit-reviews] review granted: [Bug 52635] Plug-in hosting WebProcess instances appear in Activity Monitor as WebProcess : [Attachment 79289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 10:00:52 PST 2011


mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 52635: Plug-in hosting WebProcess instances appear in Activity Monitor as
WebProcess
https://bugs.webkit.org/show_bug.cgi?id=52635

Attachment 79289: Patch
https://bugs.webkit.org/attachment.cgi?id=79289&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=79289&action=review

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:87
> +    };      
> +    

No need for these spaces.

> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:99
> +				    [[(NSString*)parameters.pluginPath
lastPathComponent] stringByDeletingPathExtension], 

Need space before the asterisk. Is this what the WebKit1 plug-in host does (use
the path, not the display name from the bundle)?


More information about the webkit-reviews mailing list