[webkit-reviews] review granted: [Bug 52327] [GTK] Move text field painting out of gtk2drawing.c : [Attachment 78826] Patch with clearer comments

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 52327: [GTK] Move text field painting out of gtk2drawing.c
https://bugs.webkit.org/show_bug.cgi?id=52327

Attachment 78826: Patch with clearer comments
https://bugs.webkit.org/attachment.cgi?id=78826&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78826&action=review

Other than improving the comment, I think this patch is good to go!

> Source/WebCore/platform/gtk/RenderThemeGtk2.cpp:372
> +    widgetContext.gtkPaintShadow(textFieldRect, widget, GTK_STATE_NORMAL,
GTK_SHADOW_IN, "entry");

I'm not sure I understand what this comment says to be honest. So GTK+ relies
on having the unfocused entry previously rendered, and then renders a smaller
but complete text entry on top of it?