[webkit-reviews] review granted: [Bug 40833] [GTK] The GTK+ EventSender needs support for beginDragWithFiles : [Attachment 78296] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 18 04:38:59 PST 2011


Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 40833: [GTK] The GTK+ EventSender needs support for beginDragWithFiles
https://bugs.webkit.org/show_bug.cgi?id=40833

Attachment 78296: Patch
https://bugs.webkit.org/attachment.cgi?id=78296&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78296&action=review

Looks good!

> Tools/DumpRenderTree/gtk/EventSender.cpp:439
> +    GFile* testFile = g_file_new_for_uri(mainFrameURI);

We should be able to use GRefPtr here, since we're using GOwnPtr for the chars
=)?

> Tools/DumpRenderTree/gtk/EventSender.cpp:452
> +	   parentDirectory = g_file_new_for_path(currentDirectory.get());

You're leaking the parentDirectory returned by g_file_get_parent() here.
Perhaps fix this just by using GRefPtr on it as well =).


More information about the webkit-reviews mailing list