[webkit-reviews] review denied: [Bug 52601] [Qt] Drag and Drop does not appear to work properly : [Attachment 79227] Patch 01
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 17 23:42:51 PST 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Ragner Magalhaes
<ragner.magalhaes at openbossa.org>'s request for review:
Bug 52601: [Qt] Drag and Drop does not appear to work properly
https://bugs.webkit.org/show_bug.cgi?id=52601
Attachment 79227: Patch 01
https://bugs.webkit.org/attachment.cgi?id=79227&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79227&action=review
> Source/WebCore/ChangeLog:8
> + Check timerId's consistency before kill it to prevent kill invalid
timer.
You need to explain how this related-to/affects the drag and drop
Also, please rephrase. Maybe something like: Ensure that timerId is valid
before *killing* it, to prevent *killing an* invalid timer.
More information about the webkit-reviews
mailing list