[webkit-reviews] review denied: [Bug 15123] Self-replicating code makes Safari hang and eventually crash : [Attachment 79215] updated fix w/ tabs(!) removed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 14:18:36 PST 2011


Andreas Kling <kling at webkit.org> has denied chris reiss
<christopher.reiss at nokia.com>'s request for review:
Bug 15123: Self-replicating code makes Safari hang and eventually crash
https://bugs.webkit.org/show_bug.cgi?id=15123

Attachment 79215: updated fix w/ tabs(!) removed
https://bugs.webkit.org/attachment.cgi?id=79215&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79215&action=review

This patch needs a ChangeLog, please see
http://trac.webkit.org/wiki/QtWebKitContrib for more information on how to make
patches.

Also, there are a number of coding style violations and unnecessary whitespace
changes, please fix those for the next iteration.

> WebCore/dom/Document.h:22
> - * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * the Free Software Foundation, Inc.,killed myspace 51 Franklin Street,
Fifth Floor,

Not sure what's going on here ;)


More information about the webkit-reviews mailing list