[webkit-reviews] review granted: [Bug 52370] Style sharing optimization no longer works on major web sites : [Attachment 79067] style fixes based on simon's comments

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 52370: Style sharing optimization no longer works on major web sites
https://bugs.webkit.org/show_bug.cgi?id=52370

Attachment 79067: style fixes based on simon's comments
https://bugs.webkit.org/attachment.cgi?id=79067&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79067&action=review

r=me

Great patch.

> Source/WebCore/css/CSSStyleSelector.cpp:574
> +    // Collect all ids and rules using silbling selectors (:first-child and
similar)

Typo.  "silbling" should be "sibling"

> Source/WebCore/css/CSSStyleSelector.cpp:2998
> +static inline bool isSiblingSelector(CSSSelector* selector)

I would just make this a member function of CSSSelector.  I can see us using it
elsewhere.