[webkit-reviews] review granted: [Bug 52554] [Qt] QtTestBrowser crashes when closing if Facebook is opened : [Attachment 79163] Review comments implemented in patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 12:37:42 PST 2011


Andreas Kling <kling at webkit.org> has granted Aparna Nandyal
<aparna.nand at wipro.com>'s request for review:
Bug 52554: [Qt] QtTestBrowser crashes when closing if Facebook is opened
https://bugs.webkit.org/show_bug.cgi?id=52554

Attachment 79163: Review comments implemented in patch
https://bugs.webkit.org/attachment.cgi?id=79163&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79163&action=review

This looks sane, r=me

> WebKitTools/ChangeLog:5
> +	   Fixing crash bug 52554

This line is redundant, we already have a reference to the bug#. Leave it out
next time :)


More information about the webkit-reviews mailing list