[webkit-reviews] review granted: [Bug 52388] REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when navigating back to an unreachable URL : [Attachment 79038] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 52388: REGRESSION: Assertion failure in
FrameLoader::continueLoadAfterWillSubmitForm() when navigating back to an
unreachable URL
https://bugs.webkit.org/show_bug.cgi?id=52388

Attachment 79038: Patch
https://bugs.webkit.org/attachment.cgi?id=79038&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79038&action=review

> Source/WebCore/history/PageCache.cpp:255
> +	   // Do not cache error pages (these can be recognized as pages with
substitute data or unreachable URLs).

Please move the check up here so that the call to
FrameLoaderClient::canCachePage is the last call.