[webkit-reviews] review granted: [Bug 51664] Refactoring: Extract RoundedIntRect class : [Attachment 79127] trying to fix the build break
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 17 10:19:43 PST 2011
Simon Fraser (smfr) <simon.fraser at apple.com> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 51664: Refactoring: Extract RoundedIntRect class
https://bugs.webkit.org/show_bug.cgi?id=51664
Attachment 79127: trying to fix the build break
https://bugs.webkit.org/attachment.cgi?id=79127&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79127&action=review
> Source/WebCore/platform/graphics/RoundedIntRect.h:48
> + Radii(const IntSize& topLeft, const IntSize& topRight, const
IntSize& bottomLeft, const IntSize& bottomRight)
> + : m_topLeft(topLeft)
> + , m_topRight(topRight)
> + , m_bottomLeft(bottomLeft)
> + , m_bottomRight(bottomRight)
> + {
> + }
> +
> + void setTopLeft(const IntSize& size) { m_topLeft = size; }
I think you should include x(), y(), width(), height(), right() and bottom()
here just as IntRect has.
More information about the webkit-reviews
mailing list