[webkit-reviews] review granted: [Bug 52574] Web Inspector: restore agents' state upon frontend reuse. : [Attachment 79166] [PATCH] Proposed change.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 07:58:09 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 52574: Web Inspector: restore agents' state upon frontend reuse.
https://bugs.webkit.org/show_bug.cgi?id=52574

Attachment 79166: [PATCH] Proposed change.
https://bugs.webkit.org/attachment.cgi?id=79166&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79166&action=review

> Source/WebCore/inspector/Inspector.idl:-188
> -	   [notify, domain=DOM] void didCommitLoad();

This method should be deleted from the front-end as well.

> Source/WebCore/inspector/front-end/inspector.js:1657
> +    this.networkManager.reset();

Why not move this call inside WebInspector.reset ?


More information about the webkit-reviews mailing list