[webkit-reviews] review denied: [Bug 49184] Flawed rendering design for QtWebKit resulting in artifacts being displayed : [Attachment 78602] Partial Patch - solves problem for TiledBackingStore

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 07:01:25 PST 2011


Simon Hausmann <hausmann at webkit.org> has denied Carol Szabo
<carol.szabo at nokia.com>'s request for review:
Bug 49184: Flawed rendering design for QtWebKit resulting in artifacts being
displayed
https://bugs.webkit.org/show_bug.cgi?id=49184

Attachment 78602: Partial Patch - solves problem for TiledBackingStore
https://bugs.webkit.org/attachment.cgi?id=78602&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I don't think the comment should be removed, because your patch only addresses
the determination of the dirty tiles (it corrects that determination).

Also with the PaintBegin() call moved up, it is now possible that PaintBegin()
is called and the early return is hit, causing us to _not_ call PaintEnd() on
the client. I think we should maintain the symmetry there.


More information about the webkit-reviews mailing list