[webkit-reviews] review granted: [Bug 52452] Web Inspector: [Extensions API] webInspector.resources.onFinished is not fired for redirected resources : [Attachment 78948] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 52452: Web Inspector: [Extensions API] webInspector.resources.onFinished is
not fired for redirected resources
https://bugs.webkit.org/show_bug.cgi?id=52452

Attachment 78948: patch
https://bugs.webkit.org/attachment.cgi?id=78948&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78948&action=review

> Source/WebCore/inspector/front-end/NetworkManager.js:183
> +	   this._finishResource(resource, time);

We should not do two refreshes per operation.

> Source/WebCore/inspector/front-end/NetworkManager.js:221
> +	   this._startResource(resource);

Audits will break on web sockets.

> Source/WebCore/inspector/front-end/NetworkManager.js:258
> +	   this._finishResource(resource, time);

ditto