[webkit-reviews] review denied: [Bug 52212] Web Inspector: Employ TextPrompt for CSS property name/value autocompletion : [Attachment 78946] [PATCH] Inherited TextPrompt to override key handlers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 01:45:47 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 52212: Web Inspector: Employ TextPrompt for CSS property name/value
autocompletion
https://bugs.webkit.org/show_bug.cgi?id=52212

Attachment 78946: [PATCH] Inherited TextPrompt to override key handlers
https://bugs.webkit.org/attachment.cgi?id=78946&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78946&action=review

r- is for managing selection in the sidebar, rest seems fine.

> Source/WebCore/inspector/front-end/CSSKeywordCompletions.js:45
> +WebInspector.CSSKeywordCompletions._colors = [

Nit: please compress to ~120 chars per line.

> Source/WebCore/inspector/front-end/CSSKeywordCompletions.js:197
> +WebInspector.CSSKeywordCompletions._colorAwareProperties = [

ditto

> Source/WebCore/inspector/front-end/CSSKeywordCompletions.js:224
> +WebInspector.CSSKeywordCompletions._propertyKeywordMap = {

ditto

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1690
> +	       finalSelectionRange.setStart(replacementTextNode, 0);

I would expect all the selection management code to move to the prompt. Why is
it still here?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1902
> +

Nit: blank line.


More information about the webkit-reviews mailing list