[webkit-reviews] review denied: [Bug 52296] [Qt]Add local storage settings to QtTestBrowser option menu : [Attachment 78965] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 16 23:57:19 PST 2011


Simon Hausmann <hausmann at webkit.org> has denied suchi <suchi.kundu at nokia.com>'s
request for review:
Bug 52296: [Qt]Add local storage settings to QtTestBrowser option menu
https://bugs.webkit.org/show_bug.cgi?id=52296

Attachment 78965: updated patch
https://bugs.webkit.org/attachment.cgi?id=78965&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
It appears that this attachment does not compile: 


cc1plus: warnings being treated as errors
../../../../Tools/QtTestBrowser/launcherwindow.cpp: In member function ‘void
LauncherWindow::createChrome()’:
../../../../Tools/QtTestBrowser/launcherwindow.cpp:281: error: unused variable
‘offlineStorageDefaultQuotaAction’


More information about the webkit-reviews mailing list