[webkit-reviews] review granted: [Bug 50050] [Qt] plugins/keyboard-events.html fails after r72717 : [Attachment 79106] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 16 12:34:22 PST 2011
Andreas Kling <kling at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 50050: [Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050
Attachment 79106: Patch
https://bugs.webkit.org/attachment.cgi?id=79106&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79106&action=review
LGTM, thanks for attending to this!
> Source/WebCore/plugins/qt/PluginViewQt.cpp:426
> + QString chr = qKeyEvent->text().left(1);
Nit: We don't abbreviate variable names in WebKit.
More information about the webkit-reviews
mailing list