[webkit-reviews] review denied: [Bug 50050] [Qt] plugins/keyboard-events.html fails after r72717 : [Attachment 79103] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 50050: [Qt] plugins/keyboard-events.html fails after r72717
https://bugs.webkit.org/show_bug.cgi?id=50050

Attachment 79103: Patch
https://bugs.webkit.org/attachment.cgi?id=79103&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79103&action=review

> Source/WebCore/plugins/qt/PluginViewQt.cpp:427
> +	   const char* chr = qKeyEvent->text().left(1).toUtf8().constData();
> +	   xEvent->xkey.keycode = XKeysymToKeycode(QX11Info::display(),
XStringToKeysym(chr));

'chr' points to deleted data on the second line since the QByteArray returned
by toUtf8() is temporary.