[webkit-reviews] review granted: [Bug 52512] REGRESSION(r73818): range.cloneContents() ignores end offset : [Attachment 79068] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 15 12:40:31 PST 2011


Adele Peterson <adele at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 52512: REGRESSION(r73818): range.cloneContents() ignores end offset
https://bugs.webkit.org/show_bug.cgi?id=52512

Attachment 79068: Patch
https://bugs.webkit.org/attachment.cgi?id=79068&action=review

------- Additional Comments from Adele Peterson <adele at apple.com>
I'm not sure I understand the intermediate change before this very well, but
this code looks right.	You're still going to always append at least the end
container's first child, since m_end.offset() won't be 0 in the inner loop.

The new test looks good too, and Dave says this also passes the other editing
tests, including the one that was failing for one of the earlier patches.

r=me!


More information about the webkit-reviews mailing list