[webkit-reviews] review denied: [Bug 42236] [Chromium] Replace ChromiumBridge::widgetSetCursor with ChromeClient::setCursor : [Attachment 79024] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 16:57:25 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Adam Klein
<adamk at chromium.org>'s request for review:
Bug 42236: [Chromium] Replace ChromiumBridge::widgetSetCursor with
ChromeClient::setCursor
https://bugs.webkit.org/show_bug.cgi?id=42236

Attachment 79024: Patch
https://bugs.webkit.org/attachment.cgi?id=79024&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79024&action=review

> Source/WebCore/platform/chromium/WidgetChromium.cpp:63
> +    FrameView* view;

Sorry, I just realized there is a much simpler way to achieve this!

HostWindow also gained a setCursor method, and you can get the HostWindow
from a Widget's parent ScrollView.  That will dramatically simplify this
code.


More information about the webkit-reviews mailing list