[webkit-reviews] review granted: [Bug 52462] tweak line selection in code review tool : [Attachment 78970] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 52462: tweak line selection in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52462

Attachment 78970: Patch
https://bugs.webkit.org/attachment.cgi?id=78970&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78970&action=review

I'm not sure I quite follow 100%, but this looks fine.

> Websites/bugs.webkit.org/ChangeLog:14
> +	   -Make it so that if you click on the line immediately above
> +	   a line that has a comment it will add a new comment instead of
> +	   adding lines to the following comment. If the last selected line
> +	   overlaps existing comment lines though they will still get
> +	   added to the existing comment.

Interesting.  That's a nice refinement.  One thing I'd like to do better is if
you drag select a bunch of lines and then move your mouse backwards, you should
"unselect" some lines.	Currently, once selected, there is no unselect.