[webkit-reviews] review requested: [Bug 46142] Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays : [Attachment 78973] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 11:54:25 PST 2011


Jer Noble <jer.noble at apple.com> has asked  for review:
Bug 46142: Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update
playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142

Attachment 78973: Patch
https://bugs.webkit.org/attachment.cgi?id=78973&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
repaint.js was not useful for these tests because the layoutTestController
needs to wait until notifyDone() is called; other tests in
LayoutTests/fast/repaint/ which call waitUntilDone() do not use repaint.js. 
But I reproduced the logic contained both in repaint.js and in other repaint
tests (such as layout-state-scrolloffset.html) within these new repaint tests. 
Also, to address Simon's comment regarding in-page media elements, a new
repaint test for in-page audio elements was added.


More information about the webkit-reviews mailing list