[webkit-reviews] review denied: [Bug 52460] [Qt] Fixed compilation when QT_NO_SHORTCUT is defined : [Attachment 78964] Fixed compilation when QT_NO_SHORTCUT is defined

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin.poulain at nokia.com> has denied Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 52460: [Qt] Fixed compilation when QT_NO_SHORTCUT is defined
https://bugs.webkit.org/show_bug.cgi?id=52460

Attachment 78964: Fixed compilation when QT_NO_SHORTCUT is defined
https://bugs.webkit.org/attachment.cgi?id=78964&action=review

------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78964&action=review

> WebKit/qt/ChangeLog:8
> +	   This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt
configuration

<Kenneth>A dot at the end of the sentence!</Kenneth>

> WebKit/qt/WebCoreSupport/EditorClientQt.cpp:484
> +#ifndef QT_NO_SHORTCUT
>	   }
> -
> +#endif

I would rather see 
} else
#endif // QT_NO_SHORTCUT
{
a dozen of lines above.