[webkit-reviews] review granted: [Bug 52453] Do some forward declaration in RenderStyle.h : [Attachment 78957] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 14 10:52:35 PST 2011
David Levin <levin at chromium.org> has granted Tony Gentilcore
<tonyg at chromium.org>'s request for review:
Bug 52453: Do some forward declaration in RenderStyle.h
https://bugs.webkit.org/show_bug.cgi?id=52453
Attachment 78957: Patch
https://bugs.webkit.org/attachment.cgi?id=78957&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78957&action=review
r+ (as long as it compiles).
One small nit.
> Source/WebCore/rendering/style/RenderStyle.h:91
> +struct ContentData;
Nit: I would put the struct into a separate grouping (like what is done in
Source/WebCore/html/HTMLFormElement.h for example).
More information about the webkit-reviews
mailing list