[webkit-reviews] review denied: [Bug 52434] [GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp : [Attachment 78915] Proposed Patch2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 14 02:40:57 PST 2011
David Levin <levin at chromium.org> has denied Joone Hur <joone at kldp.org>'s
request for review:
Bug 52434: [GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=52434
Attachment 78915: Proposed Patch2
https://bugs.webkit.org/attachment.cgi?id=78915&action=review
------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78915&action=review
Now that I had a second chance to look at it. I think it could be slightly
better since you are making this change. Sorry for not noticing last time.
> Source/WebCore/platform/gtk/FileSystemGtk.cpp:51
> return string;
I wonder why you don't just do
return String(escapedString.get());
And the same for the other three places where you did a change.
More information about the webkit-reviews
mailing list