[webkit-reviews] review granted: [Bug 52292] Web Inspector: redirected resources not handled properly in Network panel : [Attachment 78823] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 52292: Web Inspector: redirected resources not handled properly in Network
panel
https://bugs.webkit.org/show_bug.cgi?id=52292

Attachment 78823: patch
https://bugs.webkit.org/attachment.cgi?id=78823&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78823&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:671
> +		   var resource = this._requestId &&
WebInspector.panels.network.resourceById(this._requestId);

Please fix this usage as well.

> Source/WebCore/inspector/front-end/NetworkManager.js:93
> +	   this._resourcesById[identifier] = resource;

Nit: _resourcesById -> _resourcesBeingLoadedById (in flight)

> Source/WebCore/inspector/front-end/NetworkManager.js:294
> +	   this._resourceTreeModel.unbindResourceURL(originalResource);

Nit: add FIXME: we should bind upon adding to the tree only (encapsulated into
ResourceTreeModel), Script debugger should do explicit late binding on its own.