[webkit-reviews] review requested: [Bug 51382] [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field. : [Attachment 78899] Fix comments and pull out setMaxHeight() call.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 00:43:38 PST 2011


Naoki Takano <takano.naoki at gmail.com> has asked  for review:
Bug 51382: [Chromium] Fix popup menu re-positioning when the menu is opened
upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382

Attachment 78899: Fix comments and pull out setMaxHeight() call.
https://bugs.webkit.org/attachment.cgi?id=78899&action=review

------- Additional Comments from Naoki Takano <takano.naoki at gmail.com>
Kent,

Could you review again?

At this time, I pull out setMaxHeight() call, so I cannot delete some RectInt
local object to call the function.
Also according to the latest source code location change, I changed the patch.

Thanks,


More information about the webkit-reviews mailing list