[webkit-reviews] review granted: [Bug 52428] check-webkit-style: _FunctionState should detect pure functions. : [Attachment 78897] Patch

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 52428: check-webkit-style: _FunctionState should detect pure functions.
https://bugs.webkit.org/show_bug.cgi?id=52428

Attachment 78897: Patch
https://bugs.webkit.org/attachment.cgi?id=78897&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78897&action=review

Looks good.

> Tools/Scripts/webkitpy/style/checkers/cpp.py:520
> +	   if not self.is_declaration:

I slightly prefer

self.is_pure = False
if self.is_declaration:
  ...
  self.is_pure = bool(...)

because is_pure will be initialized even if someone happen to add elif-clause
here. I think this comment is just my personal preference so please feel free
to ignore this.