[webkit-reviews] review granted: [Bug 52419] REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL : [Attachment 78882] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted mitz at webkit.org's request for
review:
Bug 52419: REGRESSION (r71884): Cross-origin XHR fails if willSendRequest
changes the URL
https://bugs.webkit.org/show_bug.cgi?id=52419

Attachment 78882: Patch
https://bugs.webkit.org/attachment.cgi?id=78882&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78882&action=review

Looks great.

> Tools/ChangeLog:8
> +	   Allow to furthur control the behavior of the willSendRequest
delegate callback by making it

furthur?

>
LayoutTests/http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt:5
> +CONSOLE MESSAGE: line 1: XMLHttpRequest cannot load
http://localhost:8000/loading/resources/foo.txt. Origin http://127.0.0.1:8000
is not allowed by Access-Control-Allow-Origin.

Please make this test explain what the expected behavior is. Does it somehow
pass on other platforms, or does it need to be added to Skipped lists?