[webkit-reviews] review denied: [Bug 46142] Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays : [Attachment 78838] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 46142: Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update
playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142

Attachment 78838: Patch
https://bugs.webkit.org/attachment.cgi?id=78838&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78838&action=review

r- to get a correct repaint test.

> LayoutTests/media/media-document-audio-rendering.html:17
> +    function frameLoaded()
> +    {
> +	   setTimeout(function() {	       
> +	       document.body.offsetLeft;
> +	       if (window.layoutTestController)
> +		   layoutTestController.notifyDone();
> +	   }, 1500);

We have infrastructure for repaint tests, see fast/resources/repaint.js

Is there a way to avoid making this test take 1.5 seconds?

> Source/WebCore/rendering/RenderMedia.cpp:163
> +	   LayoutStateMaintainer statePusher(view(), this, IntSize(x(), y()),
hasTransform() || hasReflection() || style()->isFlippedBlocksWritingMode());
> +

So this also may change behavior of an in-page audio element, particularly when
transformed or reflected. You may also want to add a repaint test for that case
too.