[webkit-reviews] review canceled: [Bug 52403] [chromium] drop backwards iteration in Linux complex text code : [Attachment 78866] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 16:13:31 PST 2011


Adam Langley <agl at chromium.org> has canceled  review:
Bug 52403: [chromium] drop backwards iteration in Linux complex text code
https://bugs.webkit.org/show_bug.cgi?id=52403

Attachment 78866: Patch
https://bugs.webkit.org/attachment.cgi?id=78866&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78866&action=review

> Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp:163
> +	   const SimpleFontData* nextFontData =
m_font->glyphDataForCharacter(m_item.string[m_item.item.pos + endOfRun],
false).fontData;

If this is a UTF16 string, will this not consider surrogate-pairs as two code
points?


More information about the webkit-reviews mailing list