[webkit-reviews] review granted: [Bug 52405] results archives from commit-queue are too large to upload : [Attachment 78869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 15:50:19 PST 2011


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 52405: results archives from commit-queue are too large to upload
https://bugs.webkit.org/show_bug.cgi?id=52405

Attachment 78869: Patch
https://bugs.webkit.org/attachment.cgi?id=78869&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78869&action=review

> Tools/Scripts/webkitpy/common/system/filesystem_mock.py:121
> +    def remove_tree(self, path, ignore_errors=False):
> +	   self.files = [file for file in self.files if not
file.startswith(path)]

You wrote a mock but no unit test!


More information about the webkit-reviews mailing list