[webkit-reviews] review requested: [Bug 51950] Word boundary finding code does not stop when entering or leaving a floating element : [Attachment 78868] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 13 15:44:27 PST 2011
Justin Garcia <justin.garcia at apple.com> has asked for review:
Bug 51950: Word boundary finding code does not stop when entering or leaving a
floating element
https://bugs.webkit.org/show_bug.cgi?id=51950
Attachment 78868: patch
https://bugs.webkit.org/attachment.cgi?id=78868&action=review
------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
> I don't quite understand why we need to check the height here. Also, does
this work when writing mode is vertical?
We don't emit for a floating or positioned element that doesn't take up any
space. This is demonstrated in:
editing/pasteboard/newlines-around-floating-or-positioned.html
I check the element's width(), too. Yes, we will emit if regardless of the
writing mode.
More information about the webkit-reviews
mailing list