[webkit-reviews] review denied: [Bug 52380] Lazily generate and store logical ordering of InlineBoxes : [Attachment 78836] Proposed Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Levi Weintraub <leviw at google.com>'s
request for review:
Bug 52380: Lazily generate and store logical ordering of InlineBoxes
https://bugs.webkit.org/show_bug.cgi?id=52380

Attachment 78836: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=78836&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78836&action=review

I suspect this is not invalidating when necessary.

> Source/WebCore/editing/visible_units.cpp:1039
> +    const Vector<InlineBox*> leafBoxesInLogicalOrder =
rootBox->leafBoxesInLogicalOrder();

I don't think you want the const here. seems meaningless.

> Source/WebCore/rendering/RootInlineBox.cpp:219
> +    m_leafBoxesInLogicalOrder.clear();

Don't we need to invalidate thsi when adding children too?

> Source/WebCore/rendering/RootInlineBox.cpp:566
> +void RootInlineBox::determineLogicalOrderOfLeafBoxes() const

I assume this is just copied from the previous location and otherwise not
modified (except to store in a vector)?