[webkit-reviews] review requested: [Bug 52380] Lazily generate and store logical ordering of InlineBoxes : [Attachment 78828] Proposed patch

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at google.com> has asked  for review:
Bug 52380: Lazily generate and store logical ordering of InlineBoxes
https://bugs.webkit.org/show_bug.cgi?id=52380

Attachment 78828: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=78828&action=review

------- Additional Comments from Levi Weintraub <leviw at google.com>
Currently, iterating across InlineBoxes logically involves an n^2 algorithm and
the result isn't stored. For RTL and BiDi content, this can represent a lot of
wasted work, particularly as new places pop up that need access to this info
(see https://bugs.webkit.org/show_bug.cgi?id=38087).

I propose lazily generating this ordering and storing it so future lookups and
iteration are O(1). I've also moved the algorithm to RootInlineBox so it
hopefully will be updated with Rendering changes.