[webkit-reviews] review requested: [Bug 52292] Web Inspector: redirected resources not handled properly in Network panel : [Attachment 78821] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 10:06:44 PST 2011


Andrey Kosyakov <caseq at chromium.org> has asked	for review:
Bug 52292: Web Inspector: redirected resources not handled properly in Network
panel
https://bugs.webkit.org/show_bug.cgi?id=52292

Attachment 78821: patch
https://bugs.webkit.org/attachment.cgi?id=78821&action=review

------- Additional Comments from Andrey Kosyakov <caseq at chromium.org>
- Moved main resource detection from identifierForInitialRequest() back to
didCommitLoad()
- Automatically bind resource to URL in ResourceTreeModel.createResource()
- Got rid of NetworkManager._createResource()
- Unbind redirected resources

Re WebInspector.networkResourcesById() and WebInspector.networkResources: the
idea is that most consumers need a list and do not (or should not) care about
resource ids, so I'm splitting the old WebInspector.networkResources "map" into
an array and a method to retrieve specific resource by id. The latter is
deprecated, sort of (it is currently used by extension server, which ultimately
should maintain its own ids, and ConsoleView, which uses it to provide
additional info for network errors).


More information about the webkit-reviews mailing list