[webkit-reviews] review granted: [Bug 52364] Make old-run-webkit-tests more robust on buildbots : [Attachment 78799] exit-after-n-failures 500 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 09:15:11 PST 2011


Darin Adler <darin at apple.com> has granted Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 52364: Make old-run-webkit-tests more robust on buildbots
https://bugs.webkit.org/show_bug.cgi?id=52364

Attachment 78799: exit-after-n-failures 500 patch
https://bugs.webkit.org/attachment.cgi?id=78799&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78799&action=review

Not great to attach two patches to the same bug.

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:196
> +		  WithProperties("--%(configuration)s"),
"--exit-after-n-crashes-or-timeouts", "20",  "--exit-after-n-failures", "500"]

Would be slightly better to have a comment explaining the reason for this.
There’s also an extra space after the comma.


More information about the webkit-reviews mailing list