[webkit-reviews] review requested: [Bug 52294] Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent. : [Attachment 78800] [patch] another version
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 13 05:53:05 PST 2011
Ilya Tikhonovsky <loislo at chromium.org> has asked for review:
Bug 52294: Web Inspector: Extract BrowserDebuggerAgent from
InspectorController, InspectorDOMAgent and InspectorDebugger agent.
https://bugs.webkit.org/show_bug.cgi?id=52294
Attachment 78800: [patch] another version
https://bugs.webkit.org/attachment.cgi?id=78800&action=review
------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
(In reply to comment #7)
> (From update of attachment 78690 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=78690&action=review
>
> > Source/WebCore/inspector/InspectorController.cpp:735
> > + restoreStickyBreakpoints();
>
> Why did this call move? Should it be done only in case there is at least one
of the agents?
done.
>
> > Source/WebCore/inspector/InspectorController.cpp:1270
> > + if (type == eventListenerBreakpointType && m_browserDebuggerAgent) {
>
> This method should become a part of a debugger agent.
The idea was to extract DOM depended debugging things into separate class.
>
> > Source/WebCore/inspector/InspectorInstrumentation.cpp:92
> > + if (browserDebuggerAgent->shouldBreakOnNodeInsertion(node, parent,
eventData)) {
>
> This logic should move into the debugger agent, InspectorInstrumentation
should do nothing but pure dispatching.
done.
>
> > Source/WebCore/inspector/InspectorInstrumentation.cpp:118
> > eventData->setString("breakpointType", domNativeBreakpointType);
>
> ditto
done.
>
> > Source/WebCore/inspector/InspectorInstrumentation.cpp:145
> > eventData->setString("breakpointType", domNativeBreakpointType);
>
> ditto
done.
More information about the webkit-reviews
mailing list