[webkit-reviews] review denied: [Bug 52292] Web Inspector: redirected resources not handled properly in Network panel : [Attachment 78696] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 52292: Web Inspector: redirected resources not handled properly in Network
panel
https://bugs.webkit.org/show_bug.cgi?id=52292

Attachment 78696: patch
https://bugs.webkit.org/attachment.cgi?id=78696&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78696&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:386
> +						     
ic->isMainResourceLoader(loader, request.url()) && request.targetType() ==
ResourceRequestBase::TargetIsMainFrame);

Nit: please extract isMainResource.

> Source/WebCore/inspector/front-end/NetworkManager.js:35
> +    this._lastIdentifier = 0;

_lastIdentifierForCachedResource ?

> Source/WebCore/inspector/front-end/NetworkManager.js:282
> +	   if (typeof identifier === "number")

This is a very dirty hack, please remove.

> Source/WebCore/inspector/front-end/NetworkPanel.js:770
> +    resourceById: function(id)

id does not make sense for resources loaded before front-end opening. Hence
WebInspector.resourceById or NetworkManager::resourceById should not exist.