[webkit-reviews] review requested: [Bug 52268] Setting outerText should convert CR/LF to <br> : [Attachment 78769] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 18:26:35 PST 2011


Emil A Eklund <eae at chromium.org> has asked  for review:
Bug 52268: Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268

Attachment 78769: Patch
https://bugs.webkit.org/attachment.cgi?id=78769&action=review

------- Additional Comments from Emil A Eklund <eae at chromium.org>
Rewrote the textToFragment method and made all the changes you suggested except
for your last comment about making textToFragment return a text node for
strings without a line break. The textToFragment method is used by setInnerText
which requires a fragment. I didn't want to make this patch any larger by
changing that but I'd be happy to make that change in a later patch if you
think it's worthwhile.


More information about the webkit-reviews mailing list