[webkit-reviews] review granted: [Bug 52241] REGRESSION(r69831): focus() in onkeypress discards input (affects chaseonline.chase.com) : [Attachment 78764] fixed per Eric's comment

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 52241: REGRESSION(r69831): focus() in onkeypress discards input (affects
chaseonline.chase.com)
https://bugs.webkit.org/show_bug.cgi?id=52241

Attachment 78764: fixed per Eric's comment
https://bugs.webkit.org/attachment.cgi?id=78764&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78764&action=review

Seems sane.

> LayoutTests/fast/forms/focus-change-on-keypress.html:36
> +    if (shouldChangeSelection)
> +	   expected = name == 'textarea' ? 'ac\n' : 'acb';
> +    else
> +	   expected = name == 'textarea' ? 'a\nc' : 'abc';

This seems slightly odd way to write this if, but oK. :)