[webkit-reviews] review granted: [Bug 51960] review tool formatted diff doesn't match the uploaded diff : [Attachment 78747] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 15:36:09 PST 2011


Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 51960: review tool formatted diff doesn't match the uploaded diff
https://bugs.webkit.org/show_bug.cgi?id=51960

Attachment 78747: Patch
https://bugs.webkit.org/attachment.cgi?id=78747&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Maybe the buffer doesn't get flushed if there's no trailing newline?  I'm
trying to imagine the disaster scenarios...  close() should flush though...


More information about the webkit-reviews mailing list