[webkit-reviews] review granted: [Bug 52323] Begin stubbing out some more BackingStore member functions : [Attachment 78731] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 14:29:12 PST 2011


Sam Weinig <sam at webkit.org> has granted Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 52323: Begin stubbing out some more BackingStore member functions
https://bugs.webkit.org/show_bug.cgi?id=52323

Attachment 78731: Patch
https://bugs.webkit.org/attachment.cgi?id=78731&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78731&action=review

> WebKit2/UIProcess/BackingStore.h:39
> +namespace WebCore {
> +    class IntRect;
> +}

The style checker will not like this.

> WebKit2/UIProcess/BackingStore.h:65
>      WebPageProxy* m_webPageProxy;

It doesn't seem like this should be necessary.


More information about the webkit-reviews mailing list