[webkit-reviews] review denied: [Bug 46142] Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update playhead location or time displays : [Attachment 78725] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 46142: Built-in HTML5 <audio> (and sometimes <video>) UI doesn't update
playhead location or time displays
https://bugs.webkit.org/show_bug.cgi?id=46142

Attachment 78725: Patch
https://bugs.webkit.org/attachment.cgi?id=78725&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78725&action=review

> Source/WebCore/rendering/RenderMedia.cpp:162
> +	   LayoutStateMaintainer statePusher(view(), this, IntSize(x(), y()),
style()->isFlippedBlocksWritingMode());

I think you may need to check hasTransform() || hasReflection() also.

It should be possible to make a repaint test that tests this.

> Source/WebCore/rendering/RenderMedia.cpp:175
> +	   setChildNeedsLayout(false);	      

You have extra whitespace at the end of this line.