[webkit-reviews] review granted: [Bug 52257] Change createObjectURL and revokeObjectURL to put under webkitURL : [Attachment 78620] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 11:52:16 PST 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jian Li
<jianli at chromium.org>'s request for review:
Bug 52257: Change createObjectURL and revokeObjectURL to put under webkitURL
https://bugs.webkit.org/show_bug.cgi?id=52257

Attachment 78620: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=78620&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78620&action=review

> Source/WebCore/DerivedSources.cpp:97
> +#include "JSDOMUrl.cpp"

nit: I think webkit style is for acronyms in identifiers/names to be either
lowercase (if at the start of a name) or UPPERCASE, so this should be
JSDOMURL.cpp.

> Source/WebCore/DerivedSources.make:150
> +    DOMUrl \

nit: DOMURL


More information about the webkit-reviews mailing list