[webkit-reviews] review denied: [Bug 50072] CSS: Element with border-radius should clip background : [Attachment 78685] Teaching RenderLayer about non-rectangular clip regions :)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Renata Hodovan
<reni at webkit.org>'s request for review:
Bug 50072: CSS: Element with border-radius should clip background
https://bugs.webkit.org/show_bug.cgi?id=50072

Attachment 78685: Teaching RenderLayer about non-rectangular clip regions :)
https://bugs.webkit.org/attachment.cgi?id=78685&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78685&action=review

> WebCore/rendering/RenderLayer.cpp:2513
> +	   if (renderer()->style()->hasBorderRadius()) {
> +	       IntSize topLeft, topRight, bottomLeft, bottomRight;
> +	       renderer()->style()->getBorderRadiiForRect(clipRectToApply,
topLeft, topRight, bottomLeft, bottomRight);
> +	       paintInfo.context->addRoundedRectClip(clipRectToApply, topLeft,
topRight, bottomLeft, bottomRight);
> +	   }

Sorry, this isn't enough. You need to change ClipRects to handle
non-rectangular regions.

To see this in your testcase, give .inner opacity for example.