[webkit-reviews] review granted: [Bug 37394] inspector/timeline-network-resource.html fails when run twice : [Attachment 78671] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 37394: inspector/timeline-network-resource.html fails when run twice
https://bugs.webkit.org/show_bug.cgi?id=37394

Attachment 78671: Patch
https://bugs.webkit.org/attachment.cgi?id=78671&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78671&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:532
> +	   bool isNowOnline = networkStateNotifier().onLine();

ditto

> Source/WebCore/inspector/InspectorInstrumentation.cpp:540
> +	   ApplicationCacheHost::Status status =
frame->loader()->documentLoader()->applicationCacheHost()->status();

It is weird that instrumentation delegate dives into the appcache domain logic.


> Source/WebCore/inspector/InspectorInstrumentation.h:630
> +inline void InspectorInstrumentation::updateApplicationCacheStatus(Frame*
frame)

You might want to change WebKit/chromium/src/ApplicationCacheHost.cpp as well.