[webkit-reviews] review granted: [Bug 51222] new-run-webkit-tests : need to support more modifiers (gpu, x86-64, etc.) : [Attachment 78609] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 51222: new-run-webkit-tests : need to support more modifiers (gpu, x86-64,
etc.)
https://bugs.webkit.org/show_bug.cgi?id=51222

Attachment 78609: Patch
https://bugs.webkit.org/attachment.cgi?id=78609&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78609&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:927
> +    BUG1 RELEASE : foo.html = FAIL
> +    BUG1 WIN RELEASE : foo.html = PASS
> +    BUG2 WIN : bar.html = FAIL
> +    BUG2 DEBUG : bar.html = PASS
> +
> +    the expectation for foo.html on a Win XP Release bot would be PASS since

> +    the scores for the first two lines are 1 and 2, respectively. However,
> +    lines three and four would produce a duplicate expectation on  a Win
> +    Debug bot since both the 'win' and the 'debug' expectations would apply.


This comment is no longer accurate, right?